This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 1/4] Change pspace_to_pspace_object to return a new reference

From: Simon Marchi <simark at simark dot ca>
To: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
Date: Sat, 15 Sep 2018 21:19:43 -0400
Subject: Re: [PATCH 1/4] Change pspace_to_pspace_object to return a new reference
References: <20180913053007.11780-1-tom@tromey.com> <20180913053007.11780-2-tom@tromey.com>

On 2018-09-13 1:30 a.m., Tom Tromey wrote:
> This changes pspace_to_pspace_object to return a new reference and
> fixes up all the callers.

Actually, I think the patch is missing a hunk or something, I get this error:

/home/simark/src/binutils-gdb/gdb/python/py-inferior.c:474:13: error: no viable conversion from 'gdbpy_ref<>' (aka 'gdb::ref_ptr<_object, gdbpy_ref_policy<_object> >') to 'PyObject *' (aka '_object *')
  PyObject *py_pspace = pspace_to_pspace_object (pspace);
            ^           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.


Simon

Follow-Ups:
- Re: [PATCH 1/4] Change pspace_to_pspace_object to return a new reference
  - From: Simon Marchi

References:
- [PATCH 0/4] Disallow the return of borrowed references
  - From: Tom Tromey
- [PATCH 1/4] Change pspace_to_pspace_object to return a new reference
  - From: Tom Tromey

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]