This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Make "list" work again in TUI
>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
Pedro> Something to keep in mind, though, is avoiding refreshes/updates
Pedro> caused by temporary thread stops while the target is running.
Pedro> E.g., if we have breakpoints with conditions that eval false,
Pedro> or e.g. a software watchpoint, we don't want the intermediate
Pedro> stops to cause a flurry of source window refreshes. I'm not
Pedro> sure whether that would invalidate what I said above, depends on
Pedro> when set_current_source_symtab_and_line is called, I suppose,
Pedro> but now I'm thinking that it probably does.
The troubling call is to set_current_sal_from_frame in normal_stop.
It seems like that one will be called frequently.
However one idea might be to have the TUI observer just set a flag, and
then continue to do the actual work in the prompt hook.
Pedro> That might suggest instead to start by seeing about trying to remove
Pedro> the select_source_symtab call from tui_refresh_frame_and_register_information.
Pedro> Why do we need that? Can we remove it and instead see about making
Pedro> tui_refresh_frame_and_register_information update the source window
Pedro> from get_current_source_symtab_and_line, if set_current_source_symtab_and_line
Pedro> was meanwhile called? I.e., refresh the source window if something changed
Pedro> "list"'s current source&line.
I'm going to give it a try.
Tom