This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v3] Logical short circuiting with argument lists


>>>>> "Richard" == Richard Bunt <richard.bunt@arm.com> writes:

Richard> Version 3 addresses review comments:

Richard> * Removed forward declaration of skip_undetermined_arglist.
Richard> * Made definition of skip_undetermined_arglist static.
Richard> * Added introductory comment to skip_undetermined_arglist.
Richard> * Dropped (*pos)+=3 into the block.
Richard> * Adjusted Tcl bracing.
Richard> * Removed string splitting in the test case.

Thanks again for the patch.

Richard> +	if (noside != EVAL_SKIP)
Richard> +	  {
Richard> +	    return evaluate_var_value (noside, exp->elts[pc + 1].block, var);
Richard> +	  }

The gdb style is no braces if there's just a single line.

Richard> +	else
Richard> +	  {
Richard> +	    /* Return a dummy value of the correct type when skipping, so
Richard> +	       that parent functions know what is to be skipped.  */
Richard> +	    return allocate_value (SYMBOL_TYPE (var));

... compared to here, where braces are mandatory.

This patch is ok with that first set of braces removed.
(You don't have to re-send it.)

thanks,
Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]