This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix crash with empty Rust enum

From: Tom Tromey <tom at tromey dot com>
To: Simon Marchi <simon dot marchi at polymtl dot ca>
Cc: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
Date: Thu, 13 Sep 2018 09:51:23 -0600
Subject: Re: [PATCH] Fix crash with empty Rust enum
References: <20180911213659.10366-1-tom@tromey.com> <2532514a403b7979fcd4ff915a644b95@polymtl.ca>

>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:

>> +gdb_test "print empty_enum_value" \
>> +    " = simple::EmptyEnum.*"
>> +gdb_test "ptype empty_enum_value" "simple::EmptyEnum.*"
>> +# Just make sure these don't crash, for the same reason.
>> +gdb_test "print empty_enum_value.0" ""
>> +gdb_test "print empty_enum_value.something" ""

Simon> Is it possible (and worth it) to put some tighter checks, but kfail
Simon> them based on the compiler version?

On reflection I think we need to wait for a version of rustc to come out
that has the enum debuginfo fixes.

Adding xfails to gdb.rust/*.exp is tracked here:
https://sourceware.org/bugzilla/show_bug.cgi?id=23624

So I am just going to move forward with the looser checks and fix this
part later.

Tom

References:
- [PATCH] Fix crash with empty Rust enum
  - From: Tom Tromey
- Re: [PATCH] Fix crash with empty Rust enum
  - From: Simon Marchi

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]