This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [Buildroot] [PATCH 2/2] package/gdb: use stat() privided by the system

From: Pedro Alves <palves at redhat dot com>
To: Rich Felker <dalias at aerifal dot cx>
Cc: Sergio Durigan Junior <sergiodj at redhat dot com>, Romain Naour <romain dot naour at smile dot fr>, Thomas Petazzoni <thomas dot petazzoni at bootlin dot com>, Romain Naour <romain dot naour at gmail dot com>, buildroot at buildroot dot org, gdb-patches at sourceware dot org
Date: Tue, 11 Sep 2018 17:04:46 +0100
Subject: Re: [Buildroot] [PATCH 2/2] package/gdb: use stat() privided by the system
References: <20180909163750.14196-1-romain.naour@gmail.com> <20180909163750.14196-2-romain.naour@gmail.com> <20180910174900.0b9f4133@windsurf> <d588888e-dccc-50c8-5a6e-9c5c46a512cb@smile.fr> <20180910224128.GT1878@brightrain.aerifal.cx> <87lg88oolv.fsf@redhat.com> <13772de6-1197-4182-e13f-3b4f27dfa22d@redhat.com> <20180911141312.GU1878@brightrain.aerifal.cx>

On 09/11/2018 03:13 PM, Rich Felker wrote:

> As an aside, the whole idea of running in-process code
> referencing/using functions in the process being debugged (like stat
> in libc) seems fragile and broken; perhaps aside from this
> inadvertently-added use in is_regular_file, there is no such code in
> the IPA stuff?

There is (or there should be) no such code in the fast path, which is
actually collecting tracepoints -- there are no syscalls in that path.
If there were, the whole point of the IPA would be thrown out the window.
There's some in setup code, but it hasn't been problematic.

Thanks,
Pedro Alves

References:
- Re: [Buildroot] [PATCH 2/2] package/gdb: use stat() privided by the system
  - From: Romain Naour
- Re: [Buildroot] [PATCH 2/2] package/gdb: use stat() privided by the system
  - From: Rich Felker
- Re: [Buildroot] [PATCH 2/2] package/gdb: use stat() privided by the system
  - From: Sergio Durigan Junior
- Re: [Buildroot] [PATCH 2/2] package/gdb: use stat() privided by the system
  - From: Pedro Alves
- Re: [Buildroot] [PATCH 2/2] package/gdb: use stat() privided by the system
  - From: Rich Felker

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]