This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2/2] Testsuite: Add gdb_simple_compile


>>>>> "Alan" == Alan Hayward <Alan.Hayward@arm.com> writes:

>> I hadn't noticed this in the first patch but I see now that
>> gdb_can_simple_compile / gdb_simple_compile set the default compiler flags.
>> 
>> Maybe it would be better to have this just be a default and let callers
>> override it?

Alan> My reasoning was that you would always want both debug and nowarnings.
Alan> Didn’t see anywhere that didn’t use them. So I always append those two to
Alan> the passed in flags. Happy to move them to the default param.

It's fine with me if you'd rather keep it, but I think it would be nice
if the proc's intro comment mentioned this.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]