This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 4/5] Support 'info proc files' on live FreeBSD processes.

From: Simon Marchi <simon dot marchi at ericsson dot com>
To: John Baldwin <jhb at FreeBSD dot org>, <gdb-patches at sourceware dot org>
Date: Sun, 9 Sep 2018 00:00:29 +0100
Subject: Re: [PATCH 4/5] Support 'info proc files' on live FreeBSD processes.
References: <20180908003659.37482-1-jhb@FreeBSD.org> <20180908003659.37482-5-jhb@FreeBSD.org>

On 2018-09-08 01:36 AM, John Baldwin wrote:
> This walks the list of struct kinfo_file objects returned by a call to
> kinfo_getfile outputting a description of each open file descriptor.

LGTM.

It would be nice to share the printing of the information between core
and live process, so that we can't forget to change one if we change the
other.  But if there are some subtle differences between both loops that
would make sharing more annoying than anything, I don't mind.

Simon

Follow-Ups:
- Re: [PATCH 4/5] Support 'info proc files' on live FreeBSD processes.
  - From: John Baldwin

References:
- [PATCH 0/5] Add a new 'info proc files' command
  - From: John Baldwin
- [PATCH 4/5] Support 'info proc files' on live FreeBSD processes.
  - From: John Baldwin

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]