This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2 PR gdb/16841] virtual inheritance via typedef cannot find base
- From: Simon Marchi <simon dot marchi at polymtl dot ca>
- To: Weimin Pan <weimin dot pan at oracle dot com>
- Cc: Simon Marchi <simon dot marchi at ericsson dot com>, gdb-patches at sourceware dot org
- Date: Sat, 08 Sep 2018 09:48:45 +0100
- Subject: Re: [PATCH v2 PR gdb/16841] virtual inheritance via typedef cannot find base
- References: <1535067835-60808-1-git-send-email-weimin.pan@oracle.com> <4958cf6a-a9ab-9448-0017-a4317d5a09ad@ericsson.com> <4864ea95-37cc-a323-c330-7d87aee92dde@oracle.com>
On 2018-09-08 01:12, Weimin Pan wrote:
Your patch still has trailing whitespaces. Try to do:
$ git format-patch HEAD^
$ git am 0001-virtual-inheritance-via-typedef-cannot-find-base.patch
and make sure you have no message other than
Applying: virtual inheritance via typedef cannot find base
It's nice to know this "git am" command. Do I use the "git am --abort"
command to
restore my original patch, correct problems, then use another "git am"
command?
You shouldn't need to use --abort in this case... In my instructions, I
forgot to mention to remove your commit before applying it again (it's
expected that applying the same patch twice doesn't work). So it should
be:
$ git format-patch HEAD^
$ git reset --hard HEAD^
$ git am 0001-virtual-inheritance-via-typedef-cannot-find-base.patch
Modifications to the patch can be done by using "git commit --amend", as
usual.
Thanks!
Simon