Re: [PATCH] Allow remote debugging over a Unix local domain socket.

[John Darrington <john at darrington dot wattle dot id dot au>]

On Fri, Sep 07, 2018 at 03:05:59PM -0600, Tom Tromey wrote:
     >>>>> "John" == John Darrington <john@darrington.wattle.id.au> writes:
     
     John> Extend the "target remote" and "target extended-remote" commands
     John> such that if the filename provided is a Unix local domain (AF_UNIX)
     John> socket, then it'll be treated as such, instead of trying to open
     John> it as if it were a character device.
     
     I think Pedro should have the final review on this, since he had more
     comments the last time around.

Okay.  Pedro?
     
     John> diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
     John> index 5068c0ac81..dae62c1787 100644
     John> --- a/gdb/doc/gdb.texinfo
     John> +++ b/gdb/doc/gdb.texinfo
     John> @@ -20703,7 +20703,8 @@ programs.
      
     John>  @code{target} command.
      
     John> +
     John> +@item target remote @var{local-socket}
     John> +@itemx target extended-remote @var{local-socket}
     
     That looked like one extra newline in there to me.
I will fix that.
     
     Now that there are 3 copies of this in gdb, it would be good to unify
     them somewhere in common/.

I agree.  But shouldn't that be the subject of a separate change?


J'