This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 9/9] C++ compile support


On 08/28/2018 10:51 AM, Tom Tromey wrote:
>>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:
> 
> Keith> The complete list of changes in this revision:
> Keith>   a) removed "(void)" everywhere
> Keith>   b) removed compile-cplus-support.c and moved functions to
> Keith>      private static members of compile_cplus_instance
> Keith>   c) removed _initialize_XYZ decls
> Keith>   d) moved decl_name to static member of compile_cplus_instance
> Keith>   e) used get instead of release in new_scope
> Keith>   f) KFAIL remaining compile-cplus.exp/compile-cplus-print.exp tests
> Keith>      and fixed a bug uncovered by missing "_no_output" buglet
> Keith>   g) std::string --> const char * to avoid allocation
> Keith>   h) removed type_code_to_string
> 
> Thank you for updating this.  This looks good to me.

With that, then, I've rebased this series and pushed it. [I also filed bugs
for the KFAILs added in the tests. All kfail tests updated with new bug numbers.]

Thank you, Tom!

Keith


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]