This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix windows-nat.c for -Wnarrowing


> From: Tom Tromey <tom@tromey.com>
> Cc: Pedro Alves <palves@redhat.com>,  gdb-patches@sourceware.org
> Date: Wed, 29 Aug 2018 12:59:52 -0600
> 
> >>>>> "Tom" == Tom Tromey <tom@tromey.com> writes:
> 
> Tom> So, I've added a DWORD cast there as well; then restore the #if.
> 
> That's not going to work either, is it?
> Since the test is
> 
> 	  for (i = 0; xlate[i].them != -1; i++)
> 
> ... and it should be for (DWORD) -1 ?

Why did you need to make .them be DWORD?  I think it should be a
'long', and then you can use -1L without any trouble.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]