This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 9/9] C++ compile support

From: Tom Tromey <tom at tromey dot com>
To: Keith Seitz <keiths at redhat dot com>
Cc: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
Date: Tue, 28 Aug 2018 11:51:42 -0600
Subject: Re: [PATCH 9/9] C++ compile support
References: <20180810232534.481-1-keiths@redhat.com> <20180810232534.481-10-keiths@redhat.com> <87tvo0sakn.fsf@tromey.com> <bc565ff6-a902-18ed-7b29-f28ca93aa3fb@redhat.com>

>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:

Keith> The complete list of changes in this revision:
Keith>   a) removed "(void)" everywhere
Keith>   b) removed compile-cplus-support.c and moved functions to
Keith>      private static members of compile_cplus_instance
Keith>   c) removed _initialize_XYZ decls
Keith>   d) moved decl_name to static member of compile_cplus_instance
Keith>   e) used get instead of release in new_scope
Keith>   f) KFAIL remaining compile-cplus.exp/compile-cplus-print.exp tests
Keith>      and fixed a bug uncovered by missing "_no_output" buglet
Keith>   g) std::string --> const char * to avoid allocation
Keith>   h) removed type_code_to_string

Thank you for updating this.  This looks good to me.

Tom

Follow-Ups:
- Re: [PATCH 9/9] C++ compile support
  - From: Keith Seitz

References:
- [PATCH 0/9] C++ Support for Compile
  - From: Keith Seitz
- [PATCH 9/9] C++ compile support
  - From: Keith Seitz
- Re: [PATCH 9/9] C++ compile support
  - From: Tom Tromey
- Re: [PATCH 9/9] C++ compile support
  - From: Keith Seitz

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]