This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFAv2 4/6] Document changes to info [args|functions|locals|variables]


> From: Philippe Waroquiers <philippe.waroquiers@skynet.be>
> Cc: Philippe Waroquiers <philippe.waroquiers@skynet.be>
> Date: Sun, 26 Aug 2018 18:53:57 +0200
> 
> Document changes to info [args|functions|locals|variables]
> 
> gdb/doc/ChangeLog
> 2018-08-26  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
> 
> 	* gdb.texinfo (Information About a Frame): Document changes
> 	to 'info args' and 'info locals'.
> 	(Examining the Symbol Table): Document changes to 'info functions'
> 	and 'info variables'.

Thanks.  I have one minor comment:

> +If @var{type_regexp} is provided, print only the arguments whose
> +types contain a match for regular expression @var{type_regexp}.
> +The matching is done with the argument type as printed by the
> +@code{whatis} command.

I'd rephrase these two sentences as one, and while at that lose one
instance of passive tense:

  If @var{type_regexp} is provided, print only the arguments whose
  types, as printed by the @code{whatis} command, contain a match for
  regular expression @var{type_regexp}.

> +Initialization types (RAII) such as @code{lock_something_t} : each
                                                              ^
That blank is redundant.

OK with this fixed.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]