This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFC] mi: print frame architecture when printing frames on an MI channel

From: Pedro Alves <palves at redhat dot com>
To: Jan Vrany <jan dot vrany at fit dot cvut dot cz>, gdb-patches at sourceware dot org, Eli Zaretskii <eliz at gnu dot org>
Date: Tue, 21 Aug 2018 16:42:14 +0100
Subject: Re: [RFC] mi: print frame architecture when printing frames on an MI channel
References: <74309b49-5797-d98b-8381-7da59be91362@redhat.com> <20180820204250.16301-1-jan.vrany@fit.cvut.cz>

On 08/20/2018 09:42 PM, Jan Vrany wrote:

> diff --git a/gdb/NEWS b/gdb/NEWS
> index 7f9466567f..43663fd315 100644
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -41,6 +41,11 @@ thread apply [all | COUNT | -COUNT] [FLAG]... COMMAND
>    FLAG arguments allow to control what output to produce and how to handle
>    errors raised when applying COMMAND to a thread.
>  
> +* MI changes
> +
> +  ** Command responses and notifications that include a frame now include
> +     the frame's architecture in a new "arch" attribute.
> +

Note that there's already an "MI changes" section, added for your
"-data-disassemble -a" patch..  The new entry should go there.

Otherwise this LGTM.

Eli, can you review the documentation bits?

Thanks,
Pedro Alves

Follow-Ups:
- Re: [RFC] mi: print frame architecture when printing frames on an MI channel
  - From: Eli Zaretskii
- [RFC] mi: print frame architecture when printing frames on an MI channel
  - From: Jan Vrany

References:
- Re: [RFC] mi: print frame architecture when printing frames on an MI channel
  - From: Pedro Alves
- [RFC] mi: print frame architecture when printing frames on an MI channel
  - From: Jan Vrany

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]