Re: [RFA 1/2] Fix regressions for multi breakpoints command line setting/clearing

[Pedro Alves <palves at redhat dot com>]

On 08/15/2018 07:23 PM, Tom Tromey wrote:
> Tom> I will test a new (much smaller) patch a bit later.
> 
> This is hilariously simpler and seems to fix the problem.
> Let me know what you think.

I think this is the right fix.  Please push.

>     Pedro pointed out that the commands being read by "commands" should
>     not be repeatable.  This patch fixes that problem, and the
>     use-after-free bug, by simply modifying read_next_line to disallow
>     repetition.

I think it'd be good to expand a bit more about the use-after-free
bug here (someone reading git logs later on won't have the context).
You already had something in the previous version of the patch,
could just copy it in.

AFAICT, the "repeat" parameter of command_line_input is always 0 now,
and so could be eliminated (in a separate patch).

Thanks,
Pedro Alves