This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 1/7] Change completion_tracker to use char type

From: Pedro Alves <palves at redhat dot com>
To: Tom Tromey <tom at tromey dot com>
Cc: gdb-patches at sourceware dot org
Date: Thu, 9 Aug 2018 19:50:28 +0100
Subject: Re: [PATCH 1/7] Change completion_tracker to use char type
References: <20180808232016.12777-1-tom@tromey.com> <20180808232016.12777-2-tom@tromey.com> <f4419039-156c-7fb2-0671-491ed0132351@redhat.com> <87d0uridpt.fsf@tromey.com>

On 08/09/2018 07:42 PM, Tom Tromey wrote:
>>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
> 
> Pedro> See comment about use of int vs char here:
> Pedro>  https://sourceware.org/ml/gdb-patches/2017-07/msg00228.html
> Pedro> Look for "Why int".
> 
> Thanks.  How about just this patch, that adds a couple of casts at the
> necessary spots?

LGTM.

Thanks,
Pedro Alves

References:
- [PATCH 0/7] Remove -Wno-narrowing
  - From: Tom Tromey
- [PATCH 1/7] Change completion_tracker to use char type
  - From: Tom Tromey
- Re: [PATCH 1/7] Change completion_tracker to use char type
  - From: Pedro Alves
- Re: [PATCH 1/7] Change completion_tracker to use char type
  - From: Tom Tromey

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]