This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: New ARI warning Thu Aug 9 01:56:05 UTC 2018


On Thu, Aug 9, 2018 at 9:00 AM, Tom Tromey <tom@tromey.com> wrote:
>>>>>> ">" == GDB Administrator <gdbadmin@sourceware.org> writes:
>
>>> 482a483
>>> gdb/riscv-tdep.h:84: code: function call in first column: Function
>>> name in first column should be restricted to function implementation
>>> gdb/riscv-tdep.h:84:riscv_software_single_step (struct regcache *regcache);
>
> Here's a patch to fix a few minor formatting issues in riscv-tdep.h,
> including the one pointed out by ARI.
>
> Let me know what you think.

Yes, it looks good to me.  I copied the function definition a little
too literally and forgot to reformat it for the header file.

I'm not familiar with ARI, I will have to read up on that.

Jim


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]