Re: gdb build problem (gdb/unittests/scoped_mmap-selftests.c)

[Simon Marchi <simon dot marchi at polymtl dot ca>]

On 2018-08-08 13:35, Tom Tromey wrote:
> > > > > > "Steve" == Steve Ellcey <sellcey@cavium.com> writes:
>
> Steve> Is anyone else still having a problem building gdb?  I saw the 
> Steve> mail about remote.c but I currently get this failure when
> Steve> building gdb with gcc 5.4.0 on an aarch64 linux box.
>
> I haven't seen this, but IIRC some distros enable _FORTIFY_SOURCE  by
> default, which changes which unused-result warnings are emitted.
>
> Does the appended work for you?
>
> I wonder if we should enable _FORTIFY_SOURCE for development builds.
>
> Tom
>
> diff --git a/gdb/unittests/scoped_mmap-selftests.c
> b/gdb/unittests/scoped_mmap-selftests.c
> index d70a56a1862..e9d4afdffc5 100644
> --- a/gdb/unittests/scoped_mmap-selftests.c
> +++ b/gdb/unittests/scoped_mmap-selftests.c
> @@ -91,7 +91,7 @@ test_normal ()
>    int fd = mkstemp (filename);
>    SELF_CHECK (fd >= 0);
>
> -  write (fd, "Hello!", 7);
> +  SELF_CHECK (write (fd, "Hello!", 7) == 7);
>    close (fd);
>
>    gdb::unlinker unlink_test_file (filename);

Oops, sorry for the breakage.  Tom's fix LGTM.

I think that enabling _FORTIFY_SOURCE can only do some good.

Simon