This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Update dg-extract-results.* from gcc


Hi Pedro,

> On 07/20/2018 12:02 PM, Rainer Orth wrote:
>> When looking at the gdb.sum file produced by dg-extract-results.sh on
>> Solaris 11/x86, I noticed some wrong sorting, like this:
>> 
>> PASS: gdb.ada/addr_arith.exp: print something'address + 0
>> PASS: gdb.ada/addr_arith.exp: print 0 + something'address
>> PASS: gdb.ada/addr_arith.exp: print something'address - 0
>> PASS: gdb.ada/addr_arith.exp: print 0 - something'address
>> 
>> Looking closer, I noticed that while dg-extract-results.sh had been
>> copied over from contrib in the gcc repo, the corresponding
>> dg-extract-results.py file had not.  The latter not only fixes the
>> sorting problem I'd observed, but is also way faster than the shell
>> version (like a factor of 50 faster).
>
> We used to have the dg-extract-results.py file, but we deleted it
> because it caused (funnily enough, sorting) problems.  See:
>
>   https://sourceware.org/ml/gdb-patches/2015-02/msg00333.html
>
> Has that sorting stability issue been meanwhile fixed upstream?

not that I can see: between the version of dg-extract-results.py removed
in early 2015 and the one in current gcc trunk, there's only added
handling for DejaGnu ERRORs and another minor change to do with
summaries that doesn't seem to change anything wrt. sorting on first
blush.

Howver, I've just run make -j16 check three times in a row on
amd64-pc-solaris2.11, followed by make -j48 check, and the only
differences were to to 200+ racy tests, the vast majority of them in
gdb.threads.  Maybe the prior problems have been due to bugs in older
versions of python?

	Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]