This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PP?] Re: [PATCH] Delete test target descriptions when exiting


On 2018-07-30 17:26, Tom Tromey wrote:
"Simon" == Simon Marchi <simon.marchi@ericsson.com> writes:

Simon> Looking at the address sanitizer output, this was a quite low hanging Simon> fruit. We create target_desc objects for testing that we never free.
Simon> Saving them in unique_ptrs takes care of it.

FWIW this looks fine to me.

Thanks, I'll push it soon.

As I mentioned a few minutes ago, I have a bunch of -fsanitize=address
and -fsanitize=undefined patches.  I sent a few a little while ago, but
I have more here.  I thought I'd mention the state of this so we can
avoid duplicating work.

I have *not* looked at the AddressSanitizer leak reports at all, and I
wasn't planning to.

Indeed, it's because you mentioned it that I took a look. I'll try to integrate that in my "standard" build.

And, I don't yet have patches for any of the existing bugs:

https://sourceware.org/bugzilla/buglist.cgi?bug_status=UNCONFIRMED&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&list_id=43341&longdesc=AddressSanitizer&longdesc_type=allwordssubstr&product=gdb&query_format=advanced

Of these, only 22860 occurs during an ordinary "make check"; for that
one I have an idea of how to fix it, but I haven't tried it.

Understood.

Thanks,

Simon


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]