Re: [PATCH 1/3] Make index reading functions more modular

[Tom Tromey <tom at tromey dot com>]

>>>>> "Simon" == Simon Marchi <simon.marchi@ericsson.com> writes:

Simon> The read_gdb_index_from_section and read_debug_names_from_section
Simon> functions read the index content, as their names state, from sections of
Simon> object files.  A following patch will make it possible to read index
Simon> content from standalone files.

Simon> This patch therefore decouples the code that reads the index content
Simon> from the code that processes that content.  Functions
Simon> dwarf2_read_gdb_index and dwarf2_read_debug_names receive callbacks that
Simon> are responsible for providing the index contents (for both the main file
Simon> and the potential dwz file).

I think this looks reasonable.  (I was hoping there would be some way to
do it without callbacks, but I didn't see a good approach to that, and
I'd guess you didn't either.)

Tom