This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[RFA v2 05/13] Call some functions in guile/ for effect
- From: Tom Tromey <tom at tromey dot com>
- To: gdb-patches at sourceware dot org
- Cc: Tom Tromey <tom at tromey dot com>
- Date: Sat, 21 Jul 2018 12:47:12 -0600
- Subject: [RFA v2 05/13] Call some functions in guile/ for effect
- References: <20180721184720.3263-1-tom@tromey.com>
This changes a couple of spots in guile/ to remove a variable
declaration but to still call a function for effect.
gdb/ChangeLog
2018-07-21 Tom Tromey <tom@tromey.com>
* guile/scm-cmd.c (gdbscm_dont_repeat): Call
cmdscm_get_valid_command_smob_arg_unsafe for effect.
* guile/scm-block.c (gdbscm_make_block_syms_iter): Call
bkscm_get_valid_block_smob_arg_unsafe for effect.
---
gdb/ChangeLog | 7 +++++++
gdb/guile/scm-block.c | 5 ++---
gdb/guile/scm-cmd.c | 6 +++---
3 files changed, 12 insertions(+), 6 deletions(-)
diff --git a/gdb/guile/scm-block.c b/gdb/guile/scm-block.c
index d4566fc1ffe..9caff799dc1 100644
--- a/gdb/guile/scm-block.c
+++ b/gdb/guile/scm-block.c
@@ -613,9 +613,8 @@ bkscm_block_syms_progress_p (SCM scm)
static SCM
gdbscm_make_block_syms_iter (SCM self)
{
- block_smob *b_smob
- = bkscm_get_valid_block_smob_arg_unsafe (self, SCM_ARG1, FUNC_NAME);
- const struct block *block = b_smob->block;
+ /* Call for side effects. */
+ bkscm_get_valid_block_smob_arg_unsafe (self, SCM_ARG1, FUNC_NAME);
SCM progress, iter;
progress = bkscm_make_block_syms_progress_smob ();
diff --git a/gdb/guile/scm-cmd.c b/gdb/guile/scm-cmd.c
index 88a98643a91..4291933e40e 100644
--- a/gdb/guile/scm-cmd.c
+++ b/gdb/guile/scm-cmd.c
@@ -267,9 +267,9 @@ gdbscm_command_valid_p (SCM self)
static SCM
gdbscm_dont_repeat (SCM self)
{
- /* We currently don't need anything from SELF, but still verify it. */
- command_smob *c_smob
- = cmdscm_get_valid_command_smob_arg_unsafe (self, SCM_ARG1, FUNC_NAME);
+ /* We currently don't need anything from SELF, but still verify it.
+ Call for side effects. */
+ cmdscm_get_valid_command_smob_arg_unsafe (self, SCM_ARG1, FUNC_NAME);
dont_repeat ();
--
2.13.6