This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFA 04/13] Call some functions in guile/ for effect

From: Simon Marchi <simark at simark dot ca>
To: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
Date: Fri, 13 Jul 2018 21:19:22 -0400
Subject: Re: [RFA 04/13] Call some functions in guile/ for effect
References: <20180712205208.32646-1-tom@tromey.com> <20180712205208.32646-5-tom@tromey.com>

On 2018-07-12 04:51 PM, Tom Tromey wrote:
> This changes a few spots in guile/ to remove a variable declaration
> but to still call a function for effect.

LGTM, though it would be nice to mention in the comments what is the
desired side-effect (if known).

Simon

Follow-Ups:
- Re: [RFA 04/13] Call some functions in guile/ for effect
  - From: Tom Tromey

References:
- [RFA 00/13] Add -Wunused-variable
  - From: Tom Tromey
- [RFA 04/13] Call some functions in guile/ for effect
  - From: Tom Tromey

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]