This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFA 03/13] Use a previously unused variable in bfin-tdep.c

From: Simon Marchi <simark at simark dot ca>
To: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
Date: Fri, 13 Jul 2018 21:17:19 -0400
Subject: Re: [RFA 03/13] Use a previously unused variable in bfin-tdep.c
References: <20180712205208.32646-1-tom@tromey.com> <20180712205208.32646-4-tom@tromey.com>

On 2018-07-12 04:51 PM, Tom Tromey wrote:
> This changes bfin_push_dummy_call to use the result of check_typedef.
> Calling check_typedef for effect was probably ok as well, but this
> seemed a little nicer.

LGTM.

Simon

References:
- [RFA 00/13] Add -Wunused-variable
  - From: Tom Tromey
- [RFA 03/13] Use a previously unused variable in bfin-tdep.c
  - From: Tom Tromey

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]