This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
On 2018-07-13 16:51, Tom Tromey wrote:
"Simon" == Simon Marchi <simark@simark.ca> writes:Simon> On 2018-07-12 04:52 PM, Tom Tromey wrote:This removes an unused declaration from value_fetch_lazy_bitfield, but leaves the call to check_typedef, because it may be called for effect.Simon> Do you know for sure this is necessary (e.g. without this, some test fails), Simon> or you are just being cautious? Just being cautious. It's entirely possible that this isn't needed. Maybe removing it is correct in that nothing in the function appears to need it, and if it causes a bug then that means that some other spot ought to have called check_typedef. Tom
Then my opinion would be to check if removing it causes any test failure. If not, I'd remove it (in its own commit such as this patch is good, so it's easy to bisect if needed).
Simon
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |