This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFA 10/13] Remove unused declaration from value.c

From: Tom Tromey <tom at tromey dot com>
To: Simon Marchi <simark at simark dot ca>
Cc: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
Date: Fri, 13 Jul 2018 14:51:04 -0600
Subject: Re: [RFA 10/13] Remove unused declaration from value.c
References: <20180712205208.32646-1-tom@tromey.com> <20180712205208.32646-11-tom@tromey.com> <97a938d0-3cf4-dc2a-b572-6e55b824cf98@simark.ca>

>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:

Simon> On 2018-07-12 04:52 PM, Tom Tromey wrote:
>> This removes an unused declaration from value_fetch_lazy_bitfield, but
>> leaves the call to check_typedef, because it may be called for effect.

Simon> Do you know for sure this is necessary (e.g. without this, some test fails),
Simon> or you are just being cautious?

Just being cautious.  It's entirely possible that this isn't needed.
Maybe removing it is correct in that nothing in the function appears to
need it, and if it causes a bug then that means that some other spot
ought to have called check_typedef.

Tom

Follow-Ups:
- Re: [RFA 10/13] Remove unused declaration from value.c
  - From: Simon Marchi

References:
- [RFA 00/13] Add -Wunused-variable
  - From: Tom Tromey
- [RFA 10/13] Remove unused declaration from value.c
  - From: Tom Tromey
- Re: [RFA 10/13] Remove unused declaration from value.c
  - From: Simon Marchi

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]