This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA 34/42] Add many methods to buildsym_compunit
- From: Simon Marchi <simark at simark dot ca>
- To: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
- Date: Tue, 10 Jul 2018 00:08:01 -0400
- Subject: Re: [RFA 34/42] Add many methods to buildsym_compunit
- References: <20180523045851.11660-1-tom@tromey.com> <20180523045851.11660-35-tom@tromey.com>
On 2018-05-23 12:58 AM, Tom Tromey wrote:
> +void
> +augment_type_symtab ()
> +{
> + gdb_assert (buildsym_compunit != nullptr);
> + buildsym_compunit->augment_type_symtab ();
> + reset_symtab_globals ();
reset_symtab_globals () is called both here and in
buildsym_compunit->augment_type_symtab, is it intended?
Same thing for end_symtab_from_static_block and the corresponding
method.
Otherwise, LGTM.
Simon