This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA 16/42] Use gdb_assert in two places in buildsym.c
- From: Tom Tromey <tom at tromey dot com>
- To: Simon Marchi <simark at simark dot ca>
- Cc: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
- Date: Mon, 09 Jul 2018 17:08:54 -0600
- Subject: Re: [RFA 16/42] Use gdb_assert in two places in buildsym.c
- References: <20180523045851.11660-1-tom@tromey.com> <20180523045851.11660-17-tom@tromey.com> <d9016fb7-02f2-3361-a5db-37227f26cba6@simark.ca>
>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:
Simon> Just a nit, but I think inverting the condition would be more readable
Simon> gdb_assert (current_subfile != NULL && current_subfile->name != NULL);
Simon> LGTM either way.
I did this.
Tom