This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA 04/42] Move last_source file to buildsym_compunit
- From: Simon Marchi <simark at simark dot ca>
- To: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
- Date: Fri, 6 Jul 2018 23:51:06 -0400
- Subject: Re: [RFA 04/42] Move last_source file to buildsym_compunit
- References: <20180523045851.11660-1-tom@tromey.com> <20180523045851.11660-5-tom@tromey.com>
On 2018-05-23 12:58 AM, Tom Tromey wrote:
> @@ -140,6 +147,12 @@ struct buildsym_compunit
> /* The subfile of the main source file. */
> struct subfile *main_subfile = nullptr;
>
> + /* Name of source file whose symbol data we are now processing. This
> + comes from a symbol of type N_SO for stabs. For Dwarf it comes
I think it's spelled DWARF (all caps)?
> + from the DW_AT_name attribute of a DW_TAG_compile_unit DIE. */
> +
> + gdb::unique_xmalloc_ptr<char> m_last_source_file;
Nit: remove the empty line between the comment and the field.
Should this new field be private?
Otherwise, LGTM.
Simon