This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] gdb: Use add_setshow_zuinteger_unlimited_cmd in remote.c
- From: Simon Marchi <simark at simark dot ca>
- To: Andrew Burgess <andrew dot burgess at embecosm dot com>, gdb-patches at sourceware dot org
- Date: Fri, 6 Jul 2018 22:00:59 -0400
- Subject: Re: [PATCH] gdb: Use add_setshow_zuinteger_unlimited_cmd in remote.c
- References: <20180702221146.20201-1-andrew.burgess@embecosm.com>
On 2018-07-02 06:11 PM, Andrew Burgess wrote:
> @@ -1728,6 +1728,36 @@ show_memory_write_packet_size (const char *args, int from_tty)
> show_memory_packet_size (&memory_write_packet_config);
> }
>
> +/* Show the number of hardware watchpoints that can be used. */
> +
> +static void
> +show_hardware_watchpoint_limit (struct ui_file *file, int from_tty,
> + struct cmd_list_element *c, const char *value)
> +{
> + fprintf_filtered (file, _("The maximum number of target hardware "
> + "watchpoints is %s.\n"), value);
> +}
> +
> +/* Show the length limit (in bytes) for hardware watchpoints. */
> +
> +static void
> +show_hardware_watchpoint_length_limit (struct ui_file *file, int from_tty,
> + struct cmd_list_element *c, const char *value)
This line is too long. Otherwise, LGTM. Thanks!
Simon