This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA 29/42] Move the symbol lists to buildsym_compunit
- From: Keith Seitz <keiths at redhat dot com>
- To: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
- Date: Fri, 6 Jul 2018 11:34:58 -0700
- Subject: Re: [RFA 29/42] Move the symbol lists to buildsym_compunit
- References: <20180523045851.11660-1-tom@tromey.com> <20180523045851.11660-30-tom@tromey.com>
On 05/22/2018 09:58 PM, Tom Tromey wrote:
> diff --git a/gdb/buildsym.c b/gdb/buildsym.c
> index 40176298a2..0e21cfd83a 100644
> --- a/gdb/buildsym.c
> +++ b/gdb/buildsym.c
> @@ -251,6 +265,20 @@ struct buildsym_compunit
> are just waiting to be built into a blockvector when finalizing the
> associated symtab. */
> struct pending_block *m_pending_blocks = nullptr;
> +
> + /* Here are the three lists that symbols are put on. */
> +
> + /* static at top level, and types */
> +
> + struct pending *m_file_symbols = nullptr;
> +
> + /* global functions and variables */
> +
> + struct pending *m_global_symbols = nullptr;
> +
> + /* everything local to lexical context */
> +
> + struct pending *m_local_symbols = nullptr;
> };
>
> /* The work-in-progress of the compunit we are building.
I know these are all cut-n-paste descriptions, but could you please update them (incomplete sentences/grammar)?
[IANAM]
Thank you,
Keith