This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[PATCH] gdb/testsuite: Run test when software watchpoints are used
- From: Andrew Burgess <andrew dot burgess at embecosm dot com>
- To: gdb-patches at sourceware dot org
- Cc: Andrew Burgess <andrew dot burgess at embecosm dot com>
- Date: Wed, 4 Jul 2018 17:40:17 +0100
- Subject: [PATCH] gdb/testsuite: Run test when software watchpoints are used
The test gdb.base/watchpoint-reuse-slot.exp can be run when software
watchpoints are in use, we just need to update one test pattern to
look for 'Watchpoint' instead of 'Hardware watchpoint' in one case.
gdb/testsuite/ChangeLog:
* gdb.base/watchpoint-reuse-slot.exp: Test can be run using
software watchpoints, we just need to update a test pattern in one
place.
---
gdb/testsuite/ChangeLog | 6 ++++++
gdb/testsuite/gdb.base/watchpoint-reuse-slot.exp | 14 ++++++++------
2 files changed, 14 insertions(+), 6 deletions(-)
diff --git a/gdb/testsuite/gdb.base/watchpoint-reuse-slot.exp b/gdb/testsuite/gdb.base/watchpoint-reuse-slot.exp
index f196b89eab..445c350ef2 100644
--- a/gdb/testsuite/gdb.base/watchpoint-reuse-slot.exp
+++ b/gdb/testsuite/gdb.base/watchpoint-reuse-slot.exp
@@ -22,11 +22,6 @@
# operation. (Note that we don't have any of these watchpoints
# trigger.)
-if [target_info exists gdb,no_hardware_watchpoints] {
- unsupported "no target support"
- return
-}
-
standard_testfile
if {[prepare_for_testing "failed to prepare" $testfile $srcfile debug]} {
@@ -193,8 +188,15 @@ proc watch_command {cmd base offset width} {
gdb_test "hbreak $expr" "Hardware assisted breakpoint \[0-9\]+ at $hex"
} elseif {$cmd == "watch"} {
set expr "*(buf.byte + $base + $offset)@$width"
+
+ if [target_info exists gdb,no_hardware_watchpoints] {
+ set wp_prefix "Watchpoint"
+ } else {
+ set wp_prefix "Hardware watchpoint"
+ }
+
gdb_test "$cmd $expr" \
- "Hardware watchpoint \[0-9\]+: [string_to_regexp $expr]"
+ "${wp_prefix} \[0-9\]+: [string_to_regexp $expr]"
} elseif {$cmd == "awatch"} {
set expr "*(buf.byte + $base + $offset)@$width"
gdb_test "$cmd $expr" \
--
2.14.4