This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v4] Fix segfault when invoking -var-info-path-expression on a dynamic varobj
- From: Simon Marchi <simark at simark dot ca>
- To: Jan Vrany <jan dot vrany at fit dot cvut dot cz>, gdb-patches at sourceware dot org
- Date: Sun, 1 Jul 2018 22:04:15 -0400
- Subject: Re: [PATCH v4] Fix segfault when invoking -var-info-path-expression on a dynamic varobj
- References: <20180628205431.27844-1-jan.vrany@fit.cvut.cz> <57e1cd0c-c9bc-896f-16a7-daa89e916079@simark.ca>
On 2018-07-01 09:43 PM, Simon Marchi wrote:
>> diff --git a/gdb/testsuite/gdb.python/py-mi-var-info-path-expression.py b/gdb/testsuite/gdb.python/py-mi-var-info-path-expression.py
>> new file mode 100644
>> index 0000000000..34d016fb89
>> --- /dev/null
>> +++ b/gdb/testsuite/gdb.python/py-mi-var-info-path-expression.py
>> @@ -0,0 +1,57 @@
>> +# Copyright (C) 2008-2018 Free Software Foundation, Inc.
>> +
>> +# This program is free software; you can redistribute it and/or modify
>> +# it under the terms of the GNU General Public License as published by
>> +# the Free Software Foundation; either version 3 of the License, or
>> +# (at your option) any later version.
>> +#
>> +# This program is distributed in the hope that it will be useful,
>> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
>> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
>> +# GNU General Public License for more details.
>> +#
>> +# You should have received a copy of the GNU General Public License
>> +# along with this program. If not, see <http://www.gnu.org/licenses/>.
>> +
>> +import sys
>> +import gdb
>> +import gdb.types
>> +
>> +# Folowing is for Python 3 compatibility...
>
> "Following"
>
> There's an extra \n at the end of py-mi-var-info-path-expression.exp, which git
> complains about.
Actually, it might be the lack of \n at the end of py-mi-var-info-path-expression.py,
please check that too.
Simon