Re: [PATCH 2/2] x86_64-windows GDB crash due to fs_base/gs_base registers

[Pedro Alves <palves at redhat dot com>]

Thanks for writing up the commit log and ChangeLog.  The commit looks
fine to me, but you should add your name there somewhere too.

One comment on a comment below.

> diff --git a/gdb/arch/amd64.c b/gdb/arch/amd64.c
> index d31d8f1..b562018 100644
> --- a/gdb/arch/amd64.c
> +++ b/gdb/arch/amd64.c
> @@ -33,10 +33,12 @@
>  
>  /* Create amd64 target descriptions according to XCR0.  If IS_X32 is
>     true, create the x32 ones.  If IS_LINUX is true, create target
> -   descriptions for Linux.  */
> +   descriptions for Linux.  If SEGMENTS is true, the include the segment
> +   registers.  */

"the include" -> "then include"

I think it'd be clearer to say:

  include the "org.gnu.gdb.i386.segments" feature registers.

because "segment registers" along makes one think of cs,ds,ss...,
but those are part of the core register set.

>  
>  target_desc *
> -amd64_create_target_description (uint64_t xcr0, bool is_x32, bool is_linux)
> +amd64_create_target_description (uint64_t xcr0, bool is_x32, bool is_linux,
> +				 bool segments)
>  {

Thanks,
Pedro Alves