This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] gdb: Eliminate the 'stop_pc' global
- From: Pedro Alves <palves at redhat dot com>
- To: GDB Patches <gdb-patches at sourceware dot org>
- Date: Thu, 28 Jun 2018 17:39:16 +0100
- Subject: Re: [PATCH] gdb: Eliminate the 'stop_pc' global
- References: <20180621165501.17051-1-palves@redhat.com>
On 06/21/2018 05:55 PM, Pedro Alves wrote:
> In my multi-target work, I need to add a few more
> scoped_restore_current_thread and switch_to_thread calls in some
> places, and in some lower-level places I was fighting against the fact
> that switch_to_thread reads/refreshes the stop_pc global.
>
> Instead of piling on workarounds, let's just finally eliminate the
> stop_pc global. We already have the per-thread
> thread_info->suspend.stop_pc field, so it's mainly a matter of using
> that more/instead.
Thanks guys for the review.
I've pushed it in now.
Thanks,
Pedro Alves