This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFA 1/2] Move ptype/o printing code to typeprint.c

From: Tom Tromey <tom at tromey dot com>
To: Sergio Durigan Junior <sergiodj at redhat dot com>
Cc: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
Date: Tue, 26 Jun 2018 14:54:22 -0600
Subject: Re: [RFA 1/2] Move ptype/o printing code to typeprint.c
References: <20180623202227.17259-1-tom@tromey.com> <20180623202227.17259-2-tom@tromey.com> <87sh5d9i58.fsf@redhat.com>

>>>>> "Sergio" == Sergio Durigan Junior <sergiodj@redhat.com> writes:

Sergio> Thanks, Tom.  I looked at the patch, and it seems OK to me.  Just one
Sergio> small nit.

>> +const int print_offset_data::indentation = 23;

Sergio> A "/* See typeprint.h.  */" comment would be nice here, IMO.

I made this change.

Tom

References:
- [RFA 0/2] Support ptype/o in Rust
  - From: Tom Tromey
- [RFA 1/2] Move ptype/o printing code to typeprint.c
  - From: Tom Tromey
- Re: [RFA 1/2] Move ptype/o printing code to typeprint.c
  - From: Sergio Durigan Junior

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]