This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Use thread_info and inferior pointers more throughout
- From: "Ulrich Weigand" <uweigand at de dot ibm dot com>
- To: palves at redhat dot com (Pedro Alves)
- Cc: tom at tromey dot com (Tom Tromey), gdb-patches at sourceware dot org
- Date: Mon, 25 Jun 2018 12:17:57 +0200 (CEST)
- Subject: Re: [PATCH] Use thread_info and inferior pointers more throughout
Pedro Alves wrote:
> (delete_thread, delete_thread_silent): Take a thread_info pointer
> instead of a ptid.
Looks like not all callers were updated; I'm seeing build bot failures:
gdb/remote-sim.c: In member function 'virtual void gdbsim_target::mourn_inferior()':
gdb/remote-sim.c:1198:50: error: cannot convert 'ptid_t' to 'thread_info*' for argument '1' to 'void delete_thread_silent(thread_info*)'
delete_thread_silent (sim_data->remote_sim_ptid);
Just from grepping, there also seem to be a number of other calls
in native code that were not updated:
go32-nat.c: delete_thread_silent (ptid);
bsd-kvm.c: delete_thread_silent (bsd_kvm_ptid);
darwin-nat.c: delete_thread (ptid_build (inf->pid, 0, old_id));
fbsd-nat.c: delete_thread (wptid);
aix-thread.c: delete_thread (gbuf[gi]->ptid);
aix-thread.c: delete_thread (gptid);
windows-nat.c: delete_thread (ptid);
procfs.c: delete_thread (retval);
procfs.c: delete_thread (retval);
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU/Linux compilers and toolchain
Ulrich.Weigand@de.ibm.com