This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Change build_address_symbolic to return std::string
- From: Tom Tromey <tom at tromey dot com>
- To: Keith Seitz <keiths at redhat dot com>
- Cc: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
- Date: Wed, 06 Jun 2018 16:37:55 -0600
- Subject: Re: [RFA] Change build_address_symbolic to return std::string
- References: <20180505162454.5619-1-tom@tromey.com> <b6b7bd36-5a25-c7bb-0273-b7dae50fdb31@redhat.com>
>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:
Keith> Did someone looks this over already?
Nope.
>> +extern int build_address_symbolic (struct gdbarch *,
>> + CORE_ADDR addr,
>> + int do_demangle,
>> + std::string *name,
>> + int *offset,
>> + std::string *filename,
>> + int *line,
>> + int *unmapped);
Keith> Since you're moving the declaration here, could you please copy
Keith> the comment from the definition here, too, while you're at it,
Keith> replacing it with the usual "See XYZ.h"? [Warning: IANAM]
Good idea, I've made this change locally.
Tom