Re: [RFA 4/6] Introduce accessors for psymtab high and low fields

[Simon Marchi <simon dot marchi at polymtl dot ca>]

On 2018-05-03 18:36, Tom Tromey wrote:
> This introduces accessors for the partial symbol table textlow and
> texthigh fields.  This lets us later arrange to relocate these values
> at their point of use.
>
> I did this conversion by renaming the fields.  I didn't rename the
> fields back afterward, thinking that on the off chance that someone
> has a patch touching this area, then a merge would helpfully break
> their compile.

Good idea to rename the field.  What do you think of renaming them to 
text_low/text_high instead?  Like in the previous patches, it would be 
nice to make the new accessors functions instead of macros.

Instead of adding "old school" accessors, another choice would have been 
to introduce methods instead and make those fields private.

Simon