This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Use uint64_t for SVE VQ
- From: Pedro Alves <palves at redhat dot com>
- To: Alan Hayward <alan dot hayward at arm dot com>, gdb-patches at sourceware dot org
- Cc: nd at arm dot com
- Date: Sat, 2 Jun 2018 11:39:32 +0100
- Subject: Re: [PATCH] Use uint64_t for SVE VQ
- References: <20180601175331.53523-1-alan.hayward@arm.com>
On 06/01/2018 06:53 PM, Alan Hayward wrote:
> 2018-06-01 Alan Hayward <alan.hayward@arm.com>
>
> * aarch64-tdep.c (aarch64_read_description): Use long for VQ.
s/long/uint64_t/.
> --- a/gdb/aarch64-tdep.c
> +++ b/gdb/aarch64-tdep.c
> @@ -2856,7 +2856,7 @@ aarch64_displaced_step_hw_singlestep (struct gdbarch *gdbarch,
> (It is not possible to set VQ to zero on an SVE system). */
>
> const target_desc *
> -aarch64_read_description (long vq)
> +aarch64_read_description (uint64_t vq)
> {
> if (vq > AARCH64_MAX_SVE_VQ)
> error (_("VQ is %ld, maximum supported value is %d"), vq,
This %ld needs to be updated to either use PRIu64 or pulongest.
There may be others, I haven't looked at the code, just the patch.
Otherwise OK.
Thanks,
Pedro Alves