This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] fix build failure with Python 3.7
- From: Pedro Alves <palves at redhat dot com>
- To: Paul dot Koning at dell dot com
- Cc: sergiodj at redhat dot com, gdb-patches at sourceware dot org
- Date: Fri, 1 Jun 2018 14:10:39 +0100
- Subject: Re: [PATCH] fix build failure with Python 3.7
- References: <96198491-96D8-42F0-9956-1C2BC9277050@dell.com> <87fu27fux2.fsf@redhat.com> <2BFDF702-C2E4-4339-ABB4-D0655063DE95@dell.com> <4e99c685-9047-bb84-8ead-ea13d4c202d3@redhat.com> <181F555B-4509-4DA2-9D10-4DF4D47D8E3F@dell.com>
On 06/01/2018 01:54 PM, Paul.Koning@dell.com wrote:
>> Can the function be made static?
>
> No; I did that first but PyMODINIT_FUNC is a #define that conflicts with "static".
I see.
>> I'm a little surprised to see the function being named "Py...", since
>> that kind of looks like stepping in Python's namespace.
>
> True. How about "init__gdb_module"?
Sounds fine to me.
Thanks,
Pedro Alves