This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[FYI] Fix fall-through comment in windows-nat.c


Now that the mingw builder in the buildbot is working again, it
pointed out a build failure due to a missing fall-through comment in
windows-nat.c.  This patch fixes the problem.

Tested by first triggering the failure with a local mingw build, then
by rebuilding successfully with the patch.

I'm checking this in as obvious.

gdb/ChangeLog
2018-05-29  Tom Tromey  <tom@tromey.com>

	* windows-nat.c (handle_exception): Update fall-through comment.
---
 gdb/ChangeLog     | 4 ++++
 gdb/windows-nat.c | 3 ++-
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 81e528c5e1..bec4e04e16 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@
+2018-05-29  Tom Tromey  <tom@tromey.com>
+
+	* windows-nat.c (handle_exception): Update fall-through comment.
+
 2018-05-29  Tom Tromey  <tom@tromey.com>
 
 	* progspace.h (so_list_ptr): Remove typedef.  Don't declare VEC.
diff --git a/gdb/windows-nat.c b/gdb/windows-nat.c
index 9655694558..608356e74b 100644
--- a/gdb/windows-nat.c
+++ b/gdb/windows-nat.c
@@ -1253,7 +1253,8 @@ handle_exception (struct target_waitstatus *ourstatus)
 	  result = HANDLE_EXCEPTION_IGNORED;
 	  break;
 	}
-	/* treat improperly formed exception as unknown, fallthrough */
+	/* treat improperly formed exception as unknown */
+	/* FALLTHROUGH */
     default:
       /* Treat unhandled first chance exceptions specially.  */
       if (current_event.u.Exception.dwFirstChance)
-- 
2.14.3


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]