Re: [RFA] Remove cleanups from dbxread.c

[Pedro Alves <palves at redhat dot com>]

On 05/25/2018 05:55 PM, Tom Tromey wrote:
>>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
> 
> Pedro> Maybe not.  Could just just smoke test some -gstabs binary, just
> Pedro> in case?
> 
> Actually, there is testsuite/gdb.stabs, so maybe it is ok.

Only the weird.exp test it seems, which builds some stabs manually.
The other tests just use the default compile routines AFAICT, so
they end up with dwarf anyway.

> 
> Pedro> I guess we could add a ctor to header_file_location, so
> Pedro> we'd could write:
> Pedro> bincl_list-> emplace_back (pst, name, instance);
> Pedro> Could even remove add_bincl_to_list then, I guess.
> 
> Pedro> Anyway, I totally understand if you want to stay strictly
> Pedro> focused on the cleanups aspect, and this is not a request.
> 
> It seemed like a good idea, and wasn't too hard, so I did it.  If it
> were harder, then I guess I wouldn't bother, since stabs seem to be on
> their way out.

Yeah.

> 
> Let me know what you think of this.

OK.

Thanks,
Pedro Alves