This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA 0/6] Make psymbols independent of the progspace


>>>>> "Tom" == Tom Tromey <tom@tromey.com> writes:

Tom> This is another old patch series that I never checked in, which I've
Tom> now rebased.

Tom> Like some earlier series -- most recently for line tables -- This
Tom> series changes partial symbols to be independent of the progspace.
Tom> This means that the data is now stored unrelocated, and could in
Tom> theory be shared across multiple objfiles.

Tom> In practice psymtabs cannot be shared yet, because they have a
Tom> backlink to the full symtab.

Tom> Patches #1-#3 are just infrastructure changes in preparation for the
Tom> main patch; and most of the real work is in patch #6.

Tom> In patch #6 I chose to adjust addresses like this:

Tom>       lo = gdbarch_adjust_dwarf2_addr (gdbarch, lo + baseaddr) - baseaddr;

Tom> I'm not sure if this is the best way.  Maybe in the line table (I
Tom> can't look at this moment and I don't recall offhand) patch I chose to
Tom> pass unrelocated addresses to gdbarch_adjust_dwarf2_addr.  It would be
Tom> good to nail down the intended meaning of this hook and adjust
Tom> accordingly.

Tom> Tested by the buildbot -- but careful review is still required,
Tom> because some of the changes are not tested there.

Ping.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]