This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA 03/12] Update core-related help strings
- From: Pedro Alves <palves at redhat dot com>
- To: Tom Tromey <tom at tromey dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 24 May 2018 18:00:35 +0100
- Subject: Re: [RFA 03/12] Update core-related help strings
- References: <20180430143731.30007-1-tom@tromey.com> <20180430143731.30007-4-tom@tromey.com> <3cfb1618-6bf4-e92b-b841-b80bba1e553e@redhat.com> <87lgcs4lma.fsf@tromey.com>
On 05/09/2018 09:31 PM, Tom Tromey wrote:
>>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
>
> Pedro> On 04/30/2018 03:37 PM, Tom Tromey wrote:
>>> diff --git a/gdb/gcore.c b/gdb/gcore.c
>>> index 5ff4e6dc77..c53810049c 100644
>>> --- a/gdb/gcore.c
>>> +++ b/gdb/gcore.c
>>> @@ -611,7 +611,8 @@ _initialize_gcore (void)
>>> {
>>> add_com ("generate-core-file", class_files, gcore_command, _("\
>>> Save a core file with the current state of the debugged process.\n\
>>> -Argument is optional filename. Default filename is 'core.<process_id>'."));
>>> +Usage: generate-core-file [FILENAME]\n\
>>> +Argument is optional filename. Default filename is 'core.PROCESS_ID'."));
>
> Pedro> Do the guidelines say anything about this? I mean, PROCESS_ID is not
> Pedro> user input, so I'm wondering whether it should be all caps, or whether
> Pedro> it was better as it was.
>
> Pedro> Otherwise looks fine.
>
> The docs don't say much, but since the PID is a meta-syntactic variable,
> I think this is the way to go.
OK.
Thanks,
Pedro Alves