Re: time to release soon? GDB 8.1.1 release 2018-05-14 update

[Tom Tromey <tom at tromey dot com>]

>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:

>> If the DWARF reader patch goes in 8.1, then I will do that.
>> Otherwise I probably won't.  I'm not very concerned about -readnow; I
>> think pretty much only gdb developers use it or should use it.

Joel> OK with me. But wouldn't the issue surface as well without -readnow,
Joel> when expanding the partial symtab?

In theory it shouldn't.

The way this works is that psymtab.c:psymtab_to_symtab, and other such
functions, should not try to expand a psymtab coming from a partial CU
(that both of these things are called "partial" is unfortunate).
Instead, these functions find the canonical user and expand that
instead, like:

  /* If it is a shared psymtab, find an unshared psymtab that includes
     it.  Any such psymtab will do.  */
  while (pst->user != NULL)
    pst = pst->user;


-readnow wasn't obeying this rule.  The fix isn't in psymtab.c, though,
because dwarf2read plays a little game to pretend that it is using the
index with -readnow, because in this mode there's no reason to make a
psymtab at all.

Maybe should still patch psym_expand_all_symtabs, but only DWARF is
using this feature, so there didn't seem to be a reason.

Joel> Regarding the DWARF reader patch, I'd say we put it in 8.1.1.

Ok, I will backport it next week.

Tom