This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 5/8] [PowerPC] Fix access to VSCR in linux targets
- From: "Ulrich Weigand" <uweigand at de dot ibm dot com>
- To: pedromfc at linux dot vnet dot ibm dot com (Pedro Franco de Carvalho)
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 18 May 2018 12:42:08 +0200 (CEST)
- Subject: Re: [PATCH 5/8] [PowerPC] Fix access to VSCR in linux targets
Pedro Franco de Carvalho wrote:
> Ulrich Weigand <uweigand@de.ibm.com> writes:
>
> > I'm wondering if we shouldn't have the common regcache_collect_regset
> > routine zero out areas covered by REGCACHE_MAP_SKIP? Then we wouldn't
> > need this extra routine here.
>
> I think this might affect the s390 target: in s390-linux-nat,
> fill_gregset uses collect_regset on a buffer that has already been
> filled through ptrace (PTRACE_PEEKUSR_AREA), which is then used to
> extract pswm, so it relies on collect_regset not changing the buffer on
> the skipped slots.
Ah, I see. Good catch! I think your original approach is OK, then.
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU/Linux compilers and toolchain
Ulrich.Weigand@de.ibm.com