This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 8/8] [PowerPC] Recognize isa205 in linux core files
- From: Pedro Franco de Carvalho <pedromfc at linux dot vnet dot ibm dot com>
- To: Ulrich Weigand <uweigand at de dot ibm dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 16 May 2018 17:53:40 -0300
- Subject: Re: [PATCH 8/8] [PowerPC] Recognize isa205 in linux core files
- References: <20180516155030.9DA61D802CA@oc3748833570.ibm.com>
Ulrich Weigand <uweigand@de.ibm.com> writes:
> Maybe this routine should now be moved to ppc-linux-tdep.c ...
>
>> + CORE_ADDR hwcap = 0;
>> +
>> + target_auxv_search (target, AT_HWCAP, &hwcap);
>> +
>> + features.isa205 = ppc_linux_has_isa205 (hwcap);
>
> ... so it can be reused here?
>
> Otherwise this looks OK to me.
Should the routine take a struct target_ops * parameter, so that
core_read_description can pass its target (for calling
target_auxv_search)? In this case all the calls in ppc_linux_nat.c would
also have to be updated.
Thanks!
Pedro