This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] [configure] Added "nfp" to the build for binutils.
- From: "Francois H. Theron" <francois dot theron at netronome dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: gcc-patches at gnu dot org, binutils at sourceware dot org, gdb-patches at sourceware dot org
- Date: Tue, 1 May 2018 13:41:51 +0200
- Subject: Re: [PATCH] [configure] Added "nfp" to the build for binutils.
- References: <20180430182141.28935-1-francois.theron@netronome.com> <20180430195210.rx3krpbwcckkjifs@adacore.com>
On 30 April 2018 at 21:52, Joel Brobecker <brobecker@adacore.com> wrote:
>> +2018-04-30 Francois H. Theron <francois.theron@netronome.com>
>> +
>> + * config.sub: Added "nfp" to basic_machine list.
>> + * configure.ac: Added "nfp" target.
>> + * configure: Regenerate.
>
> I am not a maintainer, but I noticed that config.sub is not being
> modified by this commit -- a small discrepancy between the patch
> and the propose ChangeLog entry.
That was a mistake when splitting the diff to have config.sub
separate. For the record, it has been accepted here after the
maintainer graciously added a ChangeLog entry and a test-case:
http://git.savannah.gnu.org/cgit/config.git/commit/?id=d23f148145b62e7dea44581097f60358118f87f8
For this patch, I can resubmit a new patch with the config.sub line
removed from ChangeLog or ask that the maintainer removes this one
line when committing. Or if I misunderstood the contribution process I
can add the now accepted config.sub to the patch and not change the
ChangeLog.
Francois