This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA 6/6] Remove long_long_align_bit gdbarch attribute
- From: Tom Tromey <tom at tromey dot com>
- To: Tom Tromey <tom at tromey dot com>
- Cc: gdb-patches at sourceware dot org, Anton Kolesov <Anton dot Kolesov at synopsys dot com>
- Date: Tue, 24 Apr 2018 09:24:31 -0600
- Subject: Re: [RFA 6/6] Remove long_long_align_bit gdbarch attribute
- References: <20180424152222.8053-1-tom@tromey.com> <20180424152222.8053-7-tom@tromey.com>
>>>>> "Tom" == Tom Tromey <tom@tromey.com> writes:
Tom> This removes the long_long_align_bit gdbarch attribute in favor of
Tom> type_align. This uncovered two possible issues.
Tom> First, arc-tdep.c claimed that long long alignment was 32 bits, but
Tom> gcc's arc.h says:
Tom> #define ADJUST_FIELD_ALIGN(FIELD, TYPE, COMPUTED) \
Tom> (TYPE_MODE (strip_array_types (TYPE)) == DFmode \
Tom> ? MIN ((COMPUTED), 32) : (COMPUTED))
Tom> Here, DFmode means "double". So, I've implemented arc_type_align
Tom> according to this. I do not have a good way to test this.
Anton, could you take a look at this part of the patch?
Tom